[all-commits] [llvm/llvm-project] 626428: [MemProf] Fix the option to disable memprof ICP (#...

[Teresa Johnson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6264288d70610c40256f96f003e14ab5e8890fb8
      https://github.com/llvm/llvm-project/commit/6264288d70610c40256f96f003e14ab5e8890fb8
  Author: Teresa Johnson <tejohnson at google.com>
  Date:   2024-10-18 (Fri, 18 Oct 2024)

  Changed paths:
    M llvm/lib/Analysis/ModuleSummaryAnalysis.cpp
    M llvm/test/ThinLTO/X86/memprof-icp.ll

  Log Message:
  -----------
  [MemProf] Fix the option to disable memprof ICP (#112917)

The -enable-memprof-indirect-call-support meant to guard the recently
added memprof ICP support was not used in enough places. Specifically,
it was not checked in mayHaveMemprofSummary, which is called from the
ThinLTO backend applyImports. This led to failures when checking the
callsite records, as we incorrectly expected records for indirect calls.

Fix the option to be checked in all necessary locations, and add
testing.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications