[all-commits] [llvm/llvm-project] 4425df: [mlir][polynomial] Add and verify constraints of c...

[Hongren Zheng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4425dfba6a1f394e958e94aa471a07bcf707136a
      https://github.com/llvm/llvm-project/commit/4425dfba6a1f394e958e94aa471a07bcf707136a
  Author: Hongren Zheng <i at zenithal.me>
  Date:   2024-10-05 (Sat, 05 Oct 2024)

  Changed paths:
    M mlir/include/mlir/Dialect/Polynomial/IR/PolynomialAttributes.td
    M mlir/lib/Dialect/Polynomial/IR/PolynomialAttributes.cpp
    M mlir/test/Dialect/Polynomial/attributes.mlir

  Log Message:
  -----------
  [mlir][polynomial] Add and verify constraints of coefficientModulus for ringAttr (#111016)

Currently the semantic of coefficientModulus is unclear and a lowering
of it faces uncertainty, for example,
https://github.com/google/heir/pull/995#issuecomment-2387394895

Also, it lacks a verifier which should conform to the definition in the
document.

This PR tries to further define the semantic of coefficientModulus and
adds a verifier for it.

Cc @j2kun for review and suggestions.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications