[all-commits] [llvm/llvm-project] b4dda4: [mlir][Transforms] Dialect conversion: Extra check...

[Matthias Springer via All-commits]

  Branch: refs/heads/users/matthias-springer/tmp_no_arg_mat
  Home:   https://github.com/llvm/llvm-project
  Commit: b4dda4929c8ae3ec2d94991d82f46191b85481e1
      https://github.com/llvm/llvm-project/commit/b4dda4929c8ae3ec2d94991d82f46191b85481e1
  Author: Matthias Springer <mspringer at nvidia.com>
  Date:   2024-10-05 (Sat, 05 Oct 2024)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  [mlir][Transforms] Dialect conversion: Extra checks during `replaceOp`

This commit adds extra checks/assertions to the `ConversionPatternRewriterImpl::notifyOpReplaced` to improve its robustness.

Replacing an `unrealized_conversion_cast` op that was created by the driver is forbidden and is now caught early during `replaceOp`. It may work in some cases, but is generally dangerous because the conversion driver keeps track of these ops. (Erasing is them is fine.) This change is also in preparation of a subsequent commit that splits the `ConversionValueMapping` into replacements and materializations (with the goal of simplifying block signature conversions).

`null` replacement values are no longer registered in the `ConversionValueMapping`. This was an oversight in #106760. `null` values in the mapping could result in crashes when using the `ConversionValueMapping` API.


  Commit: e52a5247fa1e463ac6e94714b298346478d64055
      https://github.com/llvm/llvm-project/commit/e52a5247fa1e463ac6e94714b298346478d64055
  Author: Matthias Springer <mspringer at nvidia.com>
  Date:   2024-10-05 (Sat, 05 Oct 2024)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp
    M mlir/test/lib/Dialect/Test/TestPatterns.cpp

  Log Message:
  -----------
  do not build argument materializations anymore


Compare: https://github.com/llvm/llvm-project/compare/3a188cbc88f4...e52a5247fa1e

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications