[all-commits] [llvm/llvm-project] dd04cf: MLIR BUILD.bazel: fold `BasicPtxBuilderInterface`...

[Benoit Jacob via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dd04cf0c9d97a6d73c832ceb6cd060ec3589876e
      https://github.com/llvm/llvm-project/commit/dd04cf0c9d97a6d73c832ceb6cd060ec3589876e
  Author: Benoit Jacob <jacob.benoit.1 at gmail.com>
  Date:   2024-10-04 (Fri, 04 Oct 2024)

  Changed paths:
    M utils/bazel/llvm-project-overlay/mlir/BUILD.bazel

  Log Message:
  -----------
  MLIR BUILD.bazel:  fold `BasicPtxBuilderInterface` into `NVVMDialect` (#111172)

While doing an integrate into downstream
https://github.com/iree-org/iree, I ran into a typical Bazel error with
`BasicPtxBuilderInterface.cpp` including `NVVMDialect.h` which was not
exposed as a header by a declared dependency. I tried fixing this the
straightforward way, by letting `:BasicPtxBuilderInterface` depend on
`:NVVMDialect` , but that caused another Bazel error: circular
dependency between these two targets, as `:NVVMDialect` was already
depending on `:BasicPtxBuilderInterface`. I tried breaking that circle
by dropping the latter dependency, but it was a real dependency in the
code, specifically in the TableGen-generated code. So in the end it
seems that these two targets just need to be fused, which this PR does.

Signed-off-by: Benoit Jacob <jacob.benoit.1 at gmail.com>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications