[all-commits] [llvm/llvm-project] 511475: [SPIRV] Make access qualifier optional for spirv.I...

[Steven Perron via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5114758b1cacb9c93c6a3c5b842d67b06d1152f7
      https://github.com/llvm/llvm-project/commit/5114758b1cacb9c93c6a3c5b842d67b06d1152f7
  Author: Steven Perron <stevenperron at google.com>
  Date:   2024-10-03 (Thu, 03 Oct 2024)

  Changed paths:
    M llvm/docs/SPIRVUsage.rst
    M llvm/lib/Target/SPIRV/SPIRVBuiltins.cpp
    M llvm/lib/Target/SPIRV/SPIRVDuplicatesTracker.h
    M llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.cpp
    M llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.cpp
    M llvm/lib/Target/SPIRV/SPIRVSymbolicOperands.td
    A llvm/test/CodeGen/SPIRV/ShaderBufferImage.ll
    A llvm/test/CodeGen/SPIRV/ShaderImage.ll

  Log Message:
  -----------
  [SPIRV] Make access qualifier optional for spirv.Image type (#110852)

The SPIRV backend has a special type named `spirv.Image`. This type is
meant to correspond to the OpTypeImage instruction in SPIR-V, but there
is one difference. The access qualifier operand in OpTypeImage is
optional. On top of that, the access qualifiers are only valid for
kernels, and not for shaders.

We want to reuse this type when generating shader from HLSL, but we
can't use the access qualifier. This commit make the access qualifer
optional in the target extension type.

The same is done for `spirv.SampledImage`.

Contributes to #81036



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications