[all-commits] [llvm/llvm-project] c08d7b: AMDGPU: Fix verifier error on tail call target in ...

Matt Arsenault via All-commits all-commits at lists.llvm.org
Thu Oct 3 10:51:18 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c08d7b3de7409aecadd7f9edfe0f3a1ce28a6374
      https://github.com/llvm/llvm-project/commit/c08d7b3de7409aecadd7f9edfe0f3a1ce28a6374
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-10-03 (Thu, 03 Oct 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIISelLowering.cpp
    M llvm/test/CodeGen/AMDGPU/isel-amdgcn-cs-chain-intrinsic-w32.ll
    M llvm/test/CodeGen/AMDGPU/isel-amdgcn-cs-chain-intrinsic-w64.ll
    A llvm/test/CodeGen/AMDGPU/tail-call-uniform-target-in-vgprs-issue110930.ll

  Log Message:
  -----------
  AMDGPU: Fix verifier error on tail call target in vgprs (#110984)

We allow tail calls of known uniform function pointers. This
would produce a verifier error if the uniform value is in VGPRs.
Insert readfirstlanes just in case this occurs, which will fold
out later if it is unnecessary.

GlobalISel should need a similar fix, but it currently does not
attempt tail calls of indirect calls.

Fixes #107447
Fixes subissue of #110930



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list