[all-commits] [llvm/llvm-project] 34d0c9: [libc++] Stop trying to avoid exporting some typei...

[Louis Dionne via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 34d0c99d82791607d96db18b94218269106ef3b8
      https://github.com/llvm/llvm-project/commit/34d0c99d82791607d96db18b94218269106ef3b8
  Author: Louis Dionne <ldionne.2 at gmail.com>
  Date:   2024-10-03 (Thu, 03 Oct 2024)

  Changed paths:
    M libcxx/lib/abi/CHANGELOG.TXT
    M libcxx/lib/abi/arm64-apple-darwin.libcxxabi.v1.stable.exceptions.nonew.abilist
    M libcxx/lib/abi/x86_64-apple-darwin.libcxxabi.v1.stable.exceptions.nonew.abilist
    R libcxx/lib/libc++unexp.exp
    M libcxx/src/CMakeLists.txt

  Log Message:
  -----------
  [libc++] Stop trying to avoid exporting some typeinfo names (#110925)

When the library was initially written, it was not built with hidden
visibility. In an attempt to reduce the number of symbols exported from
libc++, an explicit list of symbols to avoid exporting was passed to the
linker. This was only done on Apple platforms.

Since then, the library has moved on in several ways. First, we now
build with hidden visibility by default, so arbitrary symbols don't get
exported from the library for no reason. Second, we have proper
visibility control via source annotations, so we export exactly what we
want to, and we do that from the sources.

This patch removes the explicit list of symbols to avoid exporting from
the library, which at this point doesn't cover much anyways. The only
symbols we will now be exporting that we were not before are some
typeinfo names for implementation-detail types. While we technically
wouldn't have to export those (I don't think any user can get their
hands on those typeinfo names), that makes the library more consistent
on all platforms.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications