[all-commits] [llvm/llvm-project] e38112: AMDGPU: Fix verifier error on tail call target in ...

[Matt Arsenault via All-commits]

  Branch: refs/heads/users/arsenm/amdgpu-readfirstlane-tail-call-callee
  Home:   https://github.com/llvm/llvm-project
  Commit: e38112186b0f8b5cf8c6f204ce71de48572f3d27
      https://github.com/llvm/llvm-project/commit/e38112186b0f8b5cf8c6f204ce71de48572f3d27
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-10-03 (Thu, 03 Oct 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/SIISelLowering.cpp
    M llvm/test/CodeGen/AMDGPU/isel-amdgcn-cs-chain-intrinsic-w32.ll
    M llvm/test/CodeGen/AMDGPU/isel-amdgcn-cs-chain-intrinsic-w64.ll
    A llvm/test/CodeGen/AMDGPU/tail-call-uniform-target-in-vgprs-issue110930.ll

  Log Message:
  -----------
  AMDGPU: Fix verifier error on tail call target in vgprs

We allow tail calls of known uniform function pointers. This
would produce a verifier error if the uniform value is in VGPRs.
Insert readfirstlanes just in case this occurs, which will fold
out later if it is unnecessary.

GlobalISel should need a similar fix, but it currently does not
attempt tail calls of indirect calls.

Fixes subissue of #110930



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications