[all-commits] [llvm/llvm-project] 5b21fd: [MLIR][Pass] Full & deterministic diagnostics (#11...

[Billy Zhu via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5b21fd298cb4fc2042a95ffb9284b778f8504e04
      https://github.com/llvm/llvm-project/commit/5b21fd298cb4fc2042a95ffb9284b778f8504e04
  Author: Billy Zhu <billyzhu at modular.com>
  Date:   2024-10-01 (Tue, 01 Oct 2024)

  Changed paths:
    M mlir/lib/Pass/Pass.cpp
    M mlir/test/Pass/crash-recovery-dynamic-failure.mlir
    A mlir/test/Pass/full_diagnostics.mlir
    M mlir/test/lib/Pass/TestPassManager.cpp

  Log Message:
  -----------
  [MLIR][Pass] Full & deterministic diagnostics (#110311)

Today, when the pass infra schedules a pass/nested-pipeline on a set of
ops, it exits early as soon as it fails on one of the ops. This leads to
non-exhaustive, and more importantly, non-deterministic error reporting
(under async).

This PR removes the early termination behavior so that all ops have a
chance to run through the current pass/nested-pipeline, and all errors
are reported (async diagnostics are already ordered). This guarantees
deterministic & full error reporting. As a result, it's also no longer
necessary to -split-input-file with one error per split when testing
with -verify-diagnostics.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications