[all-commits] [llvm/llvm-project] 56649e: [MLIR][OpenMP] Use map format to represent use_dev...

[Sergio Afonso via All-commits]

  Branch: refs/heads/users/skatrak/block-args-03-usedevice
  Home:   https://github.com/llvm/llvm-project
  Commit: 56649e8ebed2fe60cde037096aff33dd3c0ccd5c
      https://github.com/llvm/llvm-project/commit/56649e8ebed2fe60cde037096aff33dd3c0ccd5c
  Author: Sergio Afonso <safonsof at amd.com>
  Date:   2024-10-01 (Tue, 01 Oct 2024)

  Changed paths:
    M flang/test/Fir/convert-to-llvm-openmp-and-fir.fir
    M flang/test/Lower/OpenMP/target.f90
    M flang/test/Lower/OpenMP/use-device-ptr-to-use-device-addr.f90
    M mlir/include/mlir/Dialect/OpenMP/OpenMPClauses.td
    M mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
    M mlir/include/mlir/Dialect/OpenMP/OpenMPOpsInterfaces.td
    M mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    M mlir/test/Dialect/OpenMP/ops.mlir
    M mlir/test/Target/LLVMIR/omptarget-llvm.mlir
    M mlir/test/Target/LLVMIR/openmp-target-use-device-nested.mlir

  Log Message:
  -----------
  [MLIR][OpenMP] Use map format to represent use_device_{addr,ptr}

This patch updates the `omp.target_data` operation to use the same formatting
as `map` clauses on `omp.target` for `use_device_addr` and `use_device_ptr`.
This is done so the mapping that is being enforced between op arguments and
associated entry block arguments is explicit.

The way it is achieved is by marking these clauses as entry block
argument-defining and adjusting printer/parsers accordingly.

As a result of this change, block arguments for `use_device_addr` come before
those for `use_device_ptr`, which is the opposite of the previous undocumented
situation. Some unit tests are updated based on this change, in addition to
those updated because of the format change.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications