[all-commits] [llvm/llvm-project] b0e2a3: [mlir][Transforms][NFC] Dialect Conversion: Simpli...

Matthias Springer via All-commits all-commits at lists.llvm.org
Tue Oct 1 00:06:32 PDT 2024


  Branch: refs/heads/users/matthias-springer/finalize_signature
  Home:   https://github.com/llvm/llvm-project
  Commit: b0e2a3a5c7d5a51cd6cdd0b307452c4db37991fd
      https://github.com/llvm/llvm-project/commit/b0e2a3a5c7d5a51cd6cdd0b307452c4db37991fd
  Author: Matthias Springer <mspringer at nvidia.com>
  Date:   2024-10-01 (Tue, 01 Oct 2024)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp

  Log Message:
  -----------
  [mlir][Transforms][NFC] Dialect Conversion: Simplify `finalize` signature

This commit simplifies the signature of `OperationConverter::finalize`. This function always returns "success", so the return value can be removed.

Note: Previously, this function used to return "failure" if a materialization failed to legalize. This is now optional and happening at a later point of time (see `config.buildMaterializations`).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list