[all-commits] [llvm/llvm-project] 78ff34: [LLDB][Minidump] Fix bug where we were using the w...

[Jacob Lalonde via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 78ff3401482384203b8ea664eee20fb81f8fb933
      https://github.com/llvm/llvm-project/commit/78ff3401482384203b8ea664eee20fb81f8fb933
  Author: Jacob Lalonde <jalalonde at fb.com>
  Date:   2024-09-30 (Mon, 30 Sep 2024)

  Changed paths:
    M lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp
    M lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.h

  Log Message:
  -----------
  [LLDB][Minidump] Fix bug where we were using the wrong collection for thread stacks (#110579)

In my prior two save core API's, I experimented on how to save stacks
with the new API. I incorrectly left these in, as the existing
`m_thread_by_range_end` was the correct choice.

I have removed the no-op collection, and moved to use the proper one.
It's worth noting this was not caught by testing because we do not
verify where the items are contained in the minidump. This would require
a test being aware of how minidumps are structured, or adding a textual
tool that we can then scan the output of.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications