[all-commits] [llvm/llvm-project] 607c52: [ARM64] [Windows] Mark block address as taken when...

[Maurice Heumann via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 607c525110ed174fa2963fc2b621109f1a95111b
      https://github.com/llvm/llvm-project/commit/607c525110ed174fa2963fc2b621109f1a95111b
  Author: Maurice Heumann <MauriceHeumann at gmail.com>
  Date:   2024-09-30 (Mon, 30 Sep 2024)

  Changed paths:
    M llvm/lib/Target/AArch64/AArch64InstrInfo.cpp
    M llvm/test/CodeGen/AArch64/pr58516.ll
    A llvm/test/CodeGen/AArch64/wineh-catchret-label-generation.ll
    M llvm/test/CodeGen/AArch64/wineh-try-catch.ll

  Log Message:
  -----------
  [ARM64] [Windows] Mark block address as taken when expanding catchrets (#109252)

This fixes issue #109250

The issue happens during the `MachineBlockPlacement` pass. The block,
whose address was previously not taken, is deemed redundant by the pass
and subsequently replaced using
`MachineBasicBlock::ReplaceUsesOfBlockWith` in `BranchFolding`.

ReplaceUsesOfBlockWith only replaces uses in the terminator. However,
`expandPostRAPseudo` introduces new block uses when expanding catchrets.
These uses do not get replaced, which results in undefined label errors
later on.

Marking the block addresss as taken prevents the replacement of the
block, without also replacing non-terminator uses.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications