[all-commits] [llvm/llvm-project] 9ac2f9: [LLDB] Fix symbol breakpoint lookups for non-C-lik...

Walter Erquinigo via All-commits all-commits at lists.llvm.org
Mon Sep 30 10:49:06 PDT 2024


  Branch: refs/heads/users/walter-erquinigo/fix-breakpoints
  Home:   https://github.com/llvm/llvm-project
  Commit: 9ac2f9b2eb34e7495e60500ce9b90cc9370e8709
      https://github.com/llvm/llvm-project/commit/9ac2f9b2eb34e7495e60500ce9b90cc9370e8709
  Author: walter erquinigo <walter at modular.com>
  Date:   2024-09-30 (Mon, 30 Sep 2024)

  Changed paths:
    M lldb/source/Breakpoint/BreakpointResolverName.cpp
    M lldb/source/Core/Module.cpp
    M lldb/source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp

  Log Message:
  -----------
  [LLDB] Fix symbol breakpoint lookups for non-C-like languages

I'm developing the Mojo language, and some symbol breakpoints don't work because of two reasons that got fixed1:

- There's a prune step that operates on the assuption that the symbol is C-like. That was discarding lots of the Mojo breakpoints
- When finding functions for symbol breakpoints with eFunctionNameTypeFull, LLDB was only matching die.getMangledName() and not die.GetName(). The latter is the one useful for Mojo, because the former has some unreadable format in Mojo that is not exposed to the user. This shouldn't cause any regression for C-like languages, as the prune step would sanitize them anyway, but it's useful for languages like Mojo.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list