[all-commits] [llvm/llvm-project] 3d9cf8: [clangd] Improve filtering logic for undesired pro...

[kadir çetinkaya via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3d9cf8b397f61f6259049a625f4888a119352e0d
      https://github.com/llvm/llvm-project/commit/3d9cf8b397f61f6259049a625f4888a119352e0d
  Author: kadir çetinkaya <kadircet at google.com>
  Date:   2024-09-30 (Mon, 30 Sep 2024)

  Changed paths:
    M clang-tools-extra/clangd/index/SymbolCollector.cpp
    M clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp

  Log Message:
  -----------
  [clangd] Improve filtering logic for undesired proto symbols (#110091)

This used to filter any names with `_` in them, apart from
enum-constants. Resulting in discrepancies in behavior when we had
fields that have `_` in the name, or for accessors like `set_`, `has_`.

The logic seems to be trying to filter mangled names for nested entries,
so adjusted logic to only do so for top-level decls, while still
preserving some public top-level helpers.

Heuristics are still leaning towards false-negatives, e.g. if a
top-level entity has `_` in its name (`message Foo_Bar {}`), it'll be
filtered, or an enum that prefixes its type name to constants
(`enum Foo { Foo_OK }`).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications