[all-commits] [llvm/llvm-project] 93998a: [AMDGPU] Fix sign confusion in performMulLoHiCombi...

Jay Foad via All-commits all-commits at lists.llvm.org
Thu Sep 12 23:52:37 PDT 2024


  Branch: refs/heads/release/19.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 93998aff7662d9b3f94d9627179dffe342e2b399
      https://github.com/llvm/llvm-project/commit/93998aff7662d9b3f94d9627179dffe342e2b399
  Author: Jay Foad <jay.foad at amd.com>
  Date:   2024-09-13 (Fri, 13 Sep 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
    M llvm/test/CodeGen/AMDGPU/mul_int24.ll

  Log Message:
  -----------
  [AMDGPU] Fix sign confusion in performMulLoHiCombine (#105831)

SMUL_LOHI and UMUL_LOHI are different operations because the high part
of the result is different, so it is not OK to optimize the signed
version to MUL_U24/MULHI_U24 or the unsigned version to
MUL_I24/MULHI_I24.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list