[all-commits] [llvm/llvm-project] ace6d5: [SandboxIR] Fix base class of FenceInst. Verify in...

[Jorge Gorbe Moya via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ace6d5f2ce53ae88205fc39dafa45e5682fd9a52
      https://github.com/llvm/llvm-project/commit/ace6d5f2ce53ae88205fc39dafa45e5682fd9a52
  Author: Jorge Gorbe Moya <jgorbe at google.com>
  Date:   2024-09-10 (Tue, 10 Sep 2024)

  Changed paths:
    M llvm/include/llvm/SandboxIR/SandboxIR.h
    M llvm/lib/SandboxIR/SandboxIR.cpp

  Log Message:
  -----------
  [SandboxIR] Fix base class of FenceInst. Verify instructions when building a BB in debug mode. (#108078)

@vporpo suggested in an offline conversation that verifying all
instructions during `BasicBlock::buildBasicBlockFromLLVMIR` would be a
good way to get coverage for errors like this during testing. He also
suggested not gating it on `SBVEC_EXPENSIVE_CHECKS` for now as the
checks are pretty basic at the moment and they only affect Debug builds.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications