[all-commits] [llvm/llvm-project] 5495c3: [WebAssembly] Misc. refactoring in AsmTypeCheck (N...

[Heejin Ahn via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5495c36104103c4172808a28e8b2df3c806b1d85
      https://github.com/llvm/llvm-project/commit/5495c36104103c4172808a28e8b2df3c806b1d85
  Author: Heejin Ahn <aheejin at gmail.com>
  Date:   2024-09-10 (Tue, 10 Sep 2024)

  Changed paths:
    M llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.cpp
    M llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmTypeCheck.h

  Log Message:
  -----------
  [WebAssembly] Misc. refactoring in AsmTypeCheck (NFC) (#107978)

Existing methods in AsmTypeCheck assumes symbol operand is the 0th
operand; they take a `MCInst` and take `getOperand(0)` on it. I think
passing a `MCOperand` removes this assumption and also is more
intuitive. This was motivated by a new `try_table` instruction, whose
support is going to be added to AsmTypeCheck soon, which has tag symbol
operands in any position, depending on the number and the kinds of catch
clauses. This PR changes all methods' signature that assumes the 0th
operand is the relevant one, even if it's not the symbol operand.

This also adds `getSignature` method, which factors out the common task
when getting a `WasmSignature` from a `MCOperand`.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications