[all-commits] [llvm/llvm-project] 8f72b0: [ELF] Fix INCLUDE cycle detection

Fangrui Song via All-commits all-commits at lists.llvm.org
Sat Jul 27 17:25:36 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8f72b0cb08d8b55ef13ed83af8dac2b7ac55208b
      https://github.com/llvm/llvm-project/commit/8f72b0cb08d8b55ef13ed83af8dac2b7ac55208b
  Author: Fangrui Song <i at maskray.me>
  Date:   2024-07-27 (Sat, 27 Jul 2024)

  Changed paths:
    M lld/ELF/ScriptLexer.cpp
    M lld/ELF/ScriptLexer.h
    M lld/ELF/ScriptParser.cpp
    M lld/test/ELF/linkerscript/include-cycle.s

  Log Message:
  -----------
  [ELF] Fix INCLUDE cycle detection

Fix #93947: the cycle detection mechanism added by
https://reviews.llvm.org/D37524 also disallowed including a file twice,
which is an unnecessary limitation.

Now that we have an include stack #100493, supporting multiple inclusion
is trivial. Note: a filename can be referenced with many different
paths, e.g. a.lds, ./a.lds, ././a.lds. We don't attempt to detect the
cycle in the earliest point.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list