[all-commits] [llvm/llvm-project] 33bdb8: [DebugInfo][SimpleLoopUnswitch] Fix missing debug ...

[Shan Huang via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 33bdb87adc16e2890beeeb64a980317e7c4292d7
      https://github.com/llvm/llvm-project/commit/33bdb87adc16e2890beeeb64a980317e7c4292d7
  Author: Shan Huang <52285902006 at stu.ecnu.edu.cn>
  Date:   2024-07-15 (Mon, 15 Jul 2024)

  Changed paths:
    M llvm/lib/Transforms/Scalar/SimpleLoopUnswitch.cpp
    A llvm/test/Transforms/SimpleLoopUnswitch/preserving-dropping-debugloc-nontrivial.ll

  Log Message:
  -----------
  [DebugInfo][SimpleLoopUnswitch] Fix missing debug location updates (#97662)

Fix #97559 .

For the change at line 1253, I propagate the debug location of the
terminator (i.e., the insertion point) to the new phi. because `MergeBB`
is generated by splitting `ExitBB` several lines above, it only has the
terminator, which could provide a reasonable debug location.

For the change at line 2348, I switch the order of moving and cloning
`TI`. Because `NewTI` cloned from `TI` is inserted into the original
place where `TI` is, `NewTI` should preserve the origianl debug
location. At the same time, doing this allows us to propagate the debug
location to the new branch instruction replacing `NewTI` (the change at
line 2446).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications