[all-commits] [llvm/llvm-project] c254f7: [mlir][Transforms] Dialect conversion: Simplify ha...

[Matthias Springer via All-commits]

  Branch: refs/heads/users/matthias-springer/block_arg_rewrite_2
  Home:   https://github.com/llvm/llvm-project
  Commit: c254f78e2636698a499a6c6baf4eb656b8e15323
      https://github.com/llvm/llvm-project/commit/c254f78e2636698a499a6c6baf4eb656b8e15323
  Author: Matthias Springer <mspringer at nvidia.com>
  Date:   2024-07-13 (Sat, 13 Jul 2024)

  Changed paths:
    M mlir/lib/Transforms/Utils/DialectConversion.cpp
    M mlir/test/Transforms/test-legalize-type-conversion.mlir

  Log Message:
  -----------
  [mlir][Transforms] Dialect conversion: Simplify handling of dropped arguments

This commit simplifies the handling of dropped arguments and updates some dialect conversion documentation that is outdated.

When converting a block signature, a BlockTypeConversionRewrite object and potentially multiple ReplaceBlockArgRewrite are created. During the "commit" phase, uses of the old block arguments are replaced with the new block arguments, but the old implementation was written in an inconsistent way: some block arguments were replaced in BlockTypeConversionRewrite::commit and some were replaced in ReplaceBlockArgRewrite::commit. The new
BlockTypeConversionRewrite::commit implementation is much simpler and no longer modifies any IR; that is done only in ReplaceBlockArgRewrite now. The ConvertedArgInfo data structure is no longer needed.

To that end, materializations of dropped arguments are now built in applySignatureConversion instead of materializeLiveConversions; the latter function no longer has to deal with dropped arguments.

Other minor improvements:

Improve variable name: origOutputType -> origArgType. Add an assertion to check that this field is only used for argument materializations.
Add more comments to applySignatureConversion.
Note: Error messages around failed materializations for dropped basic block arguments changed slightly. That is because those materializations are now built in legalizeUnresolvedMaterialization instead of legalizeConvertedArgumentTypes.

This commit is in preparation of decoupling argument/source/target materializations from the dialect conversion.

This is a re-upload of #96207.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications