[all-commits] [llvm/llvm-project] 29b93b: AMDGPU: Assume true in getVOPNIsSingle helpers

Matt Arsenault via All-commits all-commits at lists.llvm.org
Thu Jul 11 11:51:02 PDT 2024


  Branch: refs/heads/users/arsenm/amdgpu-assume-true-vop-is-single-helpers
  Home:   https://github.com/llvm/llvm-project
  Commit: 29b93ba4c3f760359db1222f9db3c4871eab6ef4
      https://github.com/llvm/llvm-project/commit/29b93ba4c3f760359db1222f9db3c4871eab6ef4
  Author: Matt Arsenault <Matthew.Arsenault at amd.com>
  Date:   2024-07-11 (Thu, 11 Jul 2024)

  Changed paths:
    M llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.cpp

  Log Message:
  -----------
  AMDGPU: Assume true in getVOPNIsSingle helpers

If we have something we don't know what it is, we should conservatively
avoid printing an additional suffix. For isCodeGenOnly pseudoinstructions,
no encoded instruction is added to the tables this is queried, and the null
case would assume true.

This happens to fix the case I ran into, but this isn't a wholistic fix.
These really should be encoded directly in the TSFlags of the MCInstrDesc,
which would allow encoding pseudos to work correctly.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list