[all-commits] [llvm/llvm-project] 8ab1dd: [DWARFLinker] Allow emission of repeated identical...

[David Tellenbach via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8ab1dd3c5196960a42965081fdf521b367e8607a
      https://github.com/llvm/llvm-project/commit/8ab1dd3c5196960a42965081fdf521b367e8607a
  Author: David Tellenbach <dtellenbach at apple.com>
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
    M llvm/lib/DWARFLinker/Classic/DWARFStreamer.cpp
    M llvm/lib/DWARFLinker/Parallel/DebugLineSectionEmitter.h
    M llvm/test/tools/dsymutil/ARM/discriminator.test
    A llvm/test/tools/dsymutil/ARM/discriminator_repeated.test
    A llvm/test/tools/dsymutil/Inputs/discriminator_repeated.arm64.dylib
    A llvm/test/tools/dsymutil/Inputs/discriminator_repeated.arm64.o

  Log Message:
  -----------
  [DWARFLinker] Allow emission of repeated identical discriminators (#98255)

Zero discriminator for each row in the line-table to correctly emit
repeated but identical discriminators.

Without this patch line-tables like

    0x0000000100003bac     12     20      0   0            65       0
    0x0000000100003bb4     12     30      0   0            65       0
    0x0000000100003bbc     12     28      0   0            65       0
    0x0000000100003bcc     12     17      0   0            65       0

get falsely linked as

    0x0000000100003bac     12     20      0   0            65       0
    0x0000000100003bb4     12     30      0   0             0       0
    0x0000000100003bbc     12     28      0   0             0       0
    0x0000000100003bcc     12     17      0   0             0       0



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications