[all-commits] [llvm/llvm-project] d5e4e7: [MLIR][OpenMP] Add TableGen pseudo-generator for O...

Sergio Afonso via All-commits all-commits at lists.llvm.org
Wed Jul 10 02:50:19 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d5e4e702aa6ba7553ea9f28e4c62ec976876c989
      https://github.com/llvm/llvm-project/commit/d5e4e702aa6ba7553ea9f28e4c62ec976876c989
  Author: Sergio Afonso <safonsof at amd.com>
  Date:   2024-07-10 (Wed, 10 Jul 2024)

  Changed paths:
    M mlir/include/mlir/Dialect/OpenMP/CMakeLists.txt
    M mlir/include/mlir/Dialect/OpenMP/OpenMPOpBase.td
    M mlir/test/lit.cfg.py
    M mlir/test/lit.site.cfg.py.in
    A mlir/test/mlir-tblgen/openmp-ops-verify.td
    M mlir/test/mlir-tblgen/openmp-ops.td
    M mlir/tools/mlir-tblgen/CMakeLists.txt
    A mlir/tools/mlir-tblgen/OmpOpGen.cpp

  Log Message:
  -----------
  [MLIR][OpenMP] Add TableGen pseudo-generator for OpenMP-specific verification (#95552)

The introduction of the clause-based approach to defining OpenMP
operations can make it more difficult to detect and address certain
programming errors derived from this change. Specifically, it's possible
for an operation to inadvertently override otherwise
automatically-populated properties and result in unexpected and
difficult to debug errors or incomplete operation definitions.

This patch introduces a TableGen backend that doesn't produce any
output, but rather only checks for these potential oversights in the
definition of OpenMP dialect operations and flags them as warnings or
errors. This provides descriptive and early feedback before any code is
attempted to be generated for these problematic definitions.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list