[all-commits] [llvm/llvm-project] 19cf8d: [compiler-rt][X86] Use functions in cpuid.h instea...

Aiden Grossman via All-commits all-commits at lists.llvm.org
Mon Jul 8 10:54:56 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 19cf8deabe1124831164987f1b9bf2f806c0a875
      https://github.com/llvm/llvm-project/commit/19cf8deabe1124831164987f1b9bf2f806c0a875
  Author: Aiden Grossman <aidengrossman at google.com>
  Date:   2024-07-08 (Mon, 08 Jul 2024)

  Changed paths:
    M compiler-rt/lib/builtins/cpu_model/x86.c
    M llvm/lib/TargetParser/Host.cpp

  Log Message:
  -----------
  [compiler-rt][X86] Use functions in cpuid.h instead of inline assembly (#97877)

This patch makes the host/feature detection in compiler-rt and LLVM use
the functions provided in cpuid.h(__get_cpuid, __get_cpuid_count)
instead of inline assembly. This simplifies the implementation and moves
any inline assembly away to a more common place.

A while ago, some similar cleanup was attempted, but this ended up
resulting in some compilation errors due to toolchain minimum version
issues (https://bugs.llvm.org/show_bug.cgi?id=30384). After the
reversion landed, there have been no attempts since then to clean up the
code, even though the minimum supported compilers now support the
relevant functions (https://godbolt.org/z/o1Mjz8ndv).



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list