[all-commits] [llvm/llvm-project] b9254a: [AArch64][RISCV] Improve the tests for --print-ena...
Tomas Matheson via All-commits
all-commits at lists.llvm.org
Mon Jul 8 05:47:24 PDT 2024
Branch: refs/heads/main
Home: https://github.com/llvm/llvm-project
Commit: b9254ade77d41c7582a98e6754058c39fd456c2a
https://github.com/llvm/llvm-project/commit/b9254ade77d41c7582a98e6754058c39fd456c2a
Author: Tomas Matheson <Tomas.Matheson at arm.com>
Date: 2024-07-08 (Mon, 08 Jul 2024)
Changed paths:
M clang/test/Driver/aarch64-v81a.c
M clang/test/Driver/aarch64-v82a.c
M clang/test/Driver/aarch64-v83a.c
M clang/test/Driver/aarch64-v84a.c
M clang/test/Driver/aarch64-v85a.c
M clang/test/Driver/aarch64-v86a.c
M clang/test/Driver/aarch64-v87a.c
M clang/test/Driver/aarch64-v88a.c
M clang/test/Driver/aarch64-v89a.c
M clang/test/Driver/aarch64-v8a.c
M clang/test/Driver/aarch64-v91a.c
M clang/test/Driver/aarch64-v92a.c
M clang/test/Driver/aarch64-v93a.c
M clang/test/Driver/aarch64-v94a.c
M clang/test/Driver/aarch64-v95a.c
M clang/test/Driver/aarch64-v9a.c
A clang/test/Driver/print-enabled-extensions/aarch64-a64fx.c
A clang/test/Driver/print-enabled-extensions/aarch64-ampere1.c
A clang/test/Driver/print-enabled-extensions/aarch64-ampere1a.c
A clang/test/Driver/print-enabled-extensions/aarch64-ampere1b.c
A clang/test/Driver/print-enabled-extensions/aarch64-apple-a10.c
A clang/test/Driver/print-enabled-extensions/aarch64-apple-a11.c
A clang/test/Driver/print-enabled-extensions/aarch64-apple-a12.c
A clang/test/Driver/print-enabled-extensions/aarch64-apple-a13.c
A clang/test/Driver/print-enabled-extensions/aarch64-apple-a14.c
A clang/test/Driver/print-enabled-extensions/aarch64-apple-a15.c
A clang/test/Driver/print-enabled-extensions/aarch64-apple-a16.c
A clang/test/Driver/print-enabled-extensions/aarch64-apple-a17.c
A clang/test/Driver/print-enabled-extensions/aarch64-apple-a7.c
A clang/test/Driver/print-enabled-extensions/aarch64-apple-m4.c
A clang/test/Driver/print-enabled-extensions/aarch64-armv8-a.c
A clang/test/Driver/print-enabled-extensions/aarch64-armv8-r.c
A clang/test/Driver/print-enabled-extensions/aarch64-armv8.1-a.c
A clang/test/Driver/print-enabled-extensions/aarch64-armv8.2-a.c
A clang/test/Driver/print-enabled-extensions/aarch64-armv8.3-a.c
A clang/test/Driver/print-enabled-extensions/aarch64-armv8.4-a.c
A clang/test/Driver/print-enabled-extensions/aarch64-armv8.5-a.c
A clang/test/Driver/print-enabled-extensions/aarch64-armv8.6-a.c
A clang/test/Driver/print-enabled-extensions/aarch64-armv8.7-a.c
A clang/test/Driver/print-enabled-extensions/aarch64-armv8.8-a.c
A clang/test/Driver/print-enabled-extensions/aarch64-armv8.9-a.c
A clang/test/Driver/print-enabled-extensions/aarch64-armv9-a.c
A clang/test/Driver/print-enabled-extensions/aarch64-armv9.1-a.c
A clang/test/Driver/print-enabled-extensions/aarch64-armv9.2-a.c
A clang/test/Driver/print-enabled-extensions/aarch64-armv9.3-a.c
A clang/test/Driver/print-enabled-extensions/aarch64-armv9.4-a.c
A clang/test/Driver/print-enabled-extensions/aarch64-armv9.5-a.c
A clang/test/Driver/print-enabled-extensions/aarch64-carmel.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a34.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a35.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a510.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a520.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a520ae.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a53.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a55.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a57.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a65.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a65ae.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a710.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a715.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a72.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a720.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a720ae.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a725.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a73.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a75.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a76.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a76ae.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a77.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a78.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a78ae.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-a78c.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-r82.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-r82ae.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-x1.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-x1c.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-x2.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-x3.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-x4.c
A clang/test/Driver/print-enabled-extensions/aarch64-cortex-x925.c
A clang/test/Driver/print-enabled-extensions/aarch64-exynos-m3.c
A clang/test/Driver/print-enabled-extensions/aarch64-exynos-m4.c
A clang/test/Driver/print-enabled-extensions/aarch64-exynos-m5.c
A clang/test/Driver/print-enabled-extensions/aarch64-falkor.c
A clang/test/Driver/print-enabled-extensions/aarch64-generic.c
A clang/test/Driver/print-enabled-extensions/aarch64-kryo.c
A clang/test/Driver/print-enabled-extensions/aarch64-neoverse-512tvb.c
A clang/test/Driver/print-enabled-extensions/aarch64-neoverse-e1.c
A clang/test/Driver/print-enabled-extensions/aarch64-neoverse-n1.c
A clang/test/Driver/print-enabled-extensions/aarch64-neoverse-n2.c
A clang/test/Driver/print-enabled-extensions/aarch64-neoverse-n3.c
A clang/test/Driver/print-enabled-extensions/aarch64-neoverse-v1.c
A clang/test/Driver/print-enabled-extensions/aarch64-neoverse-v2.c
A clang/test/Driver/print-enabled-extensions/aarch64-neoverse-v3.c
A clang/test/Driver/print-enabled-extensions/aarch64-neoverse-v3ae.c
A clang/test/Driver/print-enabled-extensions/aarch64-oryon-1.c
A clang/test/Driver/print-enabled-extensions/aarch64-saphira.c
A clang/test/Driver/print-enabled-extensions/aarch64-thunderx.c
A clang/test/Driver/print-enabled-extensions/aarch64-thunderx2t99.c
A clang/test/Driver/print-enabled-extensions/aarch64-thunderx3t110.c
A clang/test/Driver/print-enabled-extensions/aarch64-thunderxt81.c
A clang/test/Driver/print-enabled-extensions/aarch64-thunderxt83.c
A clang/test/Driver/print-enabled-extensions/aarch64-thunderxt88.c
A clang/test/Driver/print-enabled-extensions/aarch64-tsv110.c
A clang/test/Driver/print-supported-extensions-aarch64.c
A clang/test/Driver/print-supported-extensions-arm.c
A clang/test/Driver/print-supported-extensions-riscv.c
M clang/test/Driver/print-supported-extensions.c
M llvm/unittests/TargetParser/TargetParserTest.cpp
Log Message:
-----------
[AArch64][RISCV] Improve the tests for --print-enabled-extensions and --print-supported-extensions (#97829)
For AArch64, we have existing tests for `--print-enabled-extensions` for
each architecture. However:
- These are added to the end of the existing tests which check for
`"-target-feature"`, which complicates them slightly.
- They do not test the descriptions printed next to each feature.
- Part of the output was tested separately in `TargetParserTest`.
- We did not have _any_ tests of this output for CPUs (only for
architectures).
Similarly, the tests for `--print-supported-extensions` do not give
complete coverage of either the full list of features or the
descriptions.
In my opinion we should be testing the full output, as this is what the
user sees. Descriptions and formatting can contain errors and be
accidentally broken.
To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications
More information about the All-commits
mailing list