[all-commits] [llvm/llvm-project] 48263b: Revert "[MC] Remove assert to work around BOLT"

Davide Italiano via All-commits all-commits at lists.llvm.org
Tue Jul 2 08:43:19 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 48263bd7e7a8b9f8de3cb9757008dd1b2b104802
      https://github.com/llvm/llvm-project/commit/48263bd7e7a8b9f8de3cb9757008dd1b2b104802
  Author: Davide Italiano <davidino at fb.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M llvm/lib/MC/MCAssembler.cpp

  Log Message:
  -----------
  Revert "[MC] Remove assert to work around BOLT"

This reverts commit c72cb2766cec0ac519a051780ae5aed42485e012.
The patch was not reviewed, and this assertion guards against incorrect
values for symbols if the linker decides to modify the layout as it
happens on some platforms. getSymbolOffset() is used for code size
estimation, among others.

Reverting for now, until we get proper code review and undersatnding of
the implications.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list