[all-commits] [llvm/llvm-project] 70969d: [flang] Improve warnings for invalid arguments whe...

Pete Steinfeld via All-commits all-commits at lists.llvm.org
Tue Jul 2 08:39:05 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 70969df73dc9797e1bb219dfb2f6b8ba854bf8ba
      https://github.com/llvm/llvm-project/commit/70969df73dc9797e1bb219dfb2f6b8ba854bf8ba
  Author: Pete Steinfeld <47540744+psteinfeld at users.noreply.github.com>
  Date:   2024-07-02 (Tue, 02 Jul 2024)

  Changed paths:
    M flang/lib/Evaluate/intrinsics-library.cpp
    M flang/test/Evaluate/folding04.f90

  Log Message:
  -----------
  [flang] Improve warnings for invalid arguments when folding host runtime (#96807)

This is another attempt at a change that Jean made to Phabricator in
https://reviews.llvm.org/D116934. That attempt ran into problems with
building on Windows.

This change improves the messages that are produced when running into
invalid arguments during constant folding.

Note that the original attempt at implementing this contained additional
code in .../llvm-project/flang/test/Evaluate/folding04.f90:
```
  !WARN: warning: argument 'x' must be strictly positive
  real(8), parameter :: nan_r8_dlog1 = dlog(-0.1_8)
  TEST_ISNAN(nan_r8_dlog1)
```
For reasons I don't understand, this additional code caused the Windows
build to fail. So this new version of the update does not contain that
code.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list