[all-commits] [llvm/llvm-project] c00ada: [Hashing] get_execution_seed: use a non-vague link...

Fangrui Song via All-commits all-commits at lists.llvm.org
Sat Jun 29 12:56:20 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c00ada070207979f092be9046a02fcfff8b9f9ce
      https://github.com/llvm/llvm-project/commit/c00ada070207979f092be9046a02fcfff8b9f9ce
  Author: Fangrui Song <i at maskray.me>
  Date:   2024-06-29 (Sat, 29 Jun 2024)

  Changed paths:
    M llvm/include/llvm/ADT/Hashing.h

  Log Message:
  -----------
  [Hashing] get_execution_seed: use a non-vague linkage symbol

Follow-up to #96282.
Since llvm/lib/Target files are compiled with -fvisibility=hidden,
the seed variable in libLLVM.so is hidden in a -DLLVM_BUILD_LLVM_DYLIB=on build.

This would cause `hash_value(std::string()), hash_value(StringRef())` to
fail since the former (might be part of the main executable) and the
latter (llvm/lib/Support/StringRef.cpp in libLLVM.so) use copies in
different components.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list