[all-commits] [llvm/llvm-project] 2628a5: Rename f8E4M3 to f8E4M3FN in mlir.extras.types py ...

Alexander Pivovarov via All-commits all-commits at lists.llvm.org
Sat Jun 29 12:48:33 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2628a5fd2431184924cdc7d6b926bfeb36b75596
      https://github.com/llvm/llvm-project/commit/2628a5fd2431184924cdc7d6b926bfeb36b75596
  Author: Alexander Pivovarov <pivovaa at amazon.com>
  Date:   2024-06-29 (Sat, 29 Jun 2024)

  Changed paths:
    M llvm/lib/Support/APFloat.cpp
    M llvm/unittests/ADT/APFloatTest.cpp
    M mlir/python/mlir/extras/types.py

  Log Message:
  -----------
  Rename f8E4M3 to f8E4M3FN in mlir.extras.types py package (#97102)

Currently `f8E4M3` is mapped to `Float8E4M3FNType`.

This PR renames `f8E4M3` to `f8E4M3FN` to accurately reflect the actual
type.

This PR is needed to avoid names conflict in upcoming PR which will add
IEEE 754 `Float8E4M3Type`.
https://github.com/llvm/llvm-project/pull/97118 Add f8E4M3 IEEE 754 type

Maksim, can you review this PR? @makslevental ?



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list