[all-commits] [llvm/llvm-project] f372bb: [OpenMP][LLVM] Clone `omp.private` op in the paren...

Kareem Ergawy via All-commits all-commits at lists.llvm.org
Sun Jun 23 03:16:57 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f372bb45e39b7eae94930fc419724e12596a8361
      https://github.com/llvm/llvm-project/commit/f372bb45e39b7eae94930fc419724e12596a8361
  Author: Kareem Ergawy <kareem.ergawy at amd.com>
  Date:   2024-06-23 (Sun, 23 Jun 2024)

  Changed paths:
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    M mlir/test/Target/LLVMIR/openmp-private.mlir

  Log Message:
  -----------
  [OpenMP][LLVM] Clone `omp.private` op in the parent module (#96024)

Fixes a crash uncovered by test 0007_0019.f90 in the Fujitsu test suite.

Previously, in the `PrivCB`, we cloned the `omp.private` op without
inserting it in the parent module of the original op. This causes issues
whenever there is an op that needs to lookup the parent module (e.g. for
symbol lookup). This PR fixes the issue by cloning in the parent module
instead of creating an orphaned op.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list