[all-commits] [llvm/llvm-project] 0ad4c8: [clang] Fix PS "selective" DLL import/export of vt...

[Andrew Ng via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0ad4c8075985a0b82c01b28750a49e9e46a8c220
      https://github.com/llvm/llvm-project/commit/0ad4c8075985a0b82c01b28750a49e9e46a8c220
  Author: Andrew Ng <andrew.ng at sony.com>
  Date:   2024-05-24 (Fri, 24 May 2024)

  Changed paths:
    M clang/lib/CodeGen/ItaniumCXXABI.cpp
    A clang/test/CodeGenCXX/ps-dllstorage-vtable-rtti.cpp
    R clang/test/CodeGenCXX/ps4-dllstorage-vtable-rtti.cpp

  Log Message:
  -----------
  [clang] Fix PS "selective" DLL import/export of vtable & typeinfo (#92579)

Prior to this patch, for "selective" DLL import/export, the vtable &
typeinfo would be imported/exported on the condition that all non-inline
virtual methods are imported/exported. This condition was based upon MS
guidelines related to "selective" DLL import/export.

However, in reality, this condition is too rigid and can result in
undefined vtable & typeinfo symbols for code that builds fine with MSVC.
Therefore, relax this condition to be if any non-inline method is
imported/exported.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications