[all-commits] [llvm/llvm-project] a66fd5: [mlir][Transforms][NFC] `GreedyPatternRewriteDrive...

Matthias Springer via All-commits all-commits at lists.llvm.org
Mon May 20 09:43:14 PDT 2024


  Branch: refs/heads/users/matthias-springer/greedy_pattern_composition
  Home:   https://github.com/llvm/llvm-project
  Commit: a66fd5697dc5fa417d1019b64b63c61d38805876
      https://github.com/llvm/llvm-project/commit/a66fd5697dc5fa417d1019b64b63c61d38805876
  Author: Matthias Springer <mspringer at nvidia.com>
  Date:   2024-05-20 (Mon, 20 May 2024)

  Changed paths:
    M mlir/include/mlir/IR/PatternMatch.h
    M mlir/lib/Transforms/Utils/GreedyPatternRewriteDriver.cpp

  Log Message:
  -----------
  [mlir][Transforms][NFC] `GreedyPatternRewriteDriver`: Use composition instead of inheritance

This commit simplifies the design of the `GreedyPatternRewriterDriver` class. This class used to inherit from both `PatternRewriter` and `RewriterBase::Listener` and then attached itself as a listener.

In the new design, the class has a `PatternRewriter` field instead of inheriting from `PatternRewriter`, which is generally perferred in object-oriented programming.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list