[all-commits] [llvm/llvm-project] 4420ea: [StringMap] Move free into StringMapImpl dtor (NFC...

Nikita Popov via All-commits all-commits at lists.llvm.org
Mon May 13 18:07:02 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4420ea7a4971eadad528c0cd609da471a7614422
      https://github.com/llvm/llvm-project/commit/4420ea7a4971eadad528c0cd609da471a7614422
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2024-05-14 (Tue, 14 May 2024)

  Changed paths:
    M llvm/include/llvm/ADT/StringMap.h

  Log Message:
  -----------
  [StringMap] Move free into StringMapImpl dtor (NFC) (#91908)

StringMapImpl allocates the memory for the table, but does not have a
dtor that free it. Instead, StringMap (which inherits from
StringMapImpl) contains the free call. I don't really see a good reason
why this free is performed in the "wrong" class, so move it into
StringMapImpl.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list