[all-commits] [llvm/llvm-project] b1c958: [AArch64] Clarify atomic load/store size condition...

[Nikita Popov via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: b1c958e50e5d58040c53e2aa822f4dfbcbf9c273
      https://github.com/llvm/llvm-project/commit/b1c958e50e5d58040c53e2aa822f4dfbcbf9c273
  Author: Nikita Popov <npopov at redhat.com>
  Date:   2024-05-14 (Tue, 14 May 2024)

  Changed paths:
    M llvm/lib/Target/AArch64/GISel/AArch64InstructionSelector.cpp

  Log Message:
  -----------
  [AArch64] Clarify atomic load/store size condition (NFCI) (#91907)

This is currently bailing out on MemSizeInBytes larger than 64 bytes.
However, the following code can only handle sizes up to 8 bytes.
Possibly there was confusion here between MemSizeInBytes and
MemSizeInBits.

I *think* that this can't actually result in an out of bounds read of
the opcode table because we'll only ever mark loads/stores of up to 8
bytes as legal (16 byte atomics are custom-legalized earlier). As such,
I've changed this condition to an assert.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications