[all-commits] [llvm/llvm-project] e513f2: [mlir][tosa] Cleanups for post-merge review commen...

[Spenser Bauman via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e513f2c69b13322d0289cbb74c91a84996382baa
      https://github.com/llvm/llvm-project/commit/e513f2c69b13322d0289cbb74c91a84996382baa
  Author: Spenser Bauman <sbauman at mathworks.com>
  Date:   2024-05-10 (Fri, 10 May 2024)

  Changed paths:
    M mlir/lib/Dialect/Tosa/Transforms/TosaInferShapes.cpp

  Log Message:
  -----------
  [mlir][tosa] Cleanups for post-merge review comments in tosa-infer-shapes (#87660)

This change addresses some of the additional review feedback on
https://github.com/llvm/llvm-project/pull/87234.

A summary of the changes:

1. Cleaned up the language to use 'roll back' rather than revert to
reduce the chance of confusion. Improved some function names as well.
2. Eliminated string comparisons on dialect names.
3. Prevented the introduction of redundant tensor.cast operations for
the same value.

---------

Co-authored-by: Spenser Bauman <sabauma at fastmail>



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications