[all-commits] [llvm/llvm-project] 878c14: [mlir-lsp] Add DiagnosticTag from LSP spec (#91396)

[Lily Brown via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 878c141adcd3a1ea47c4cc8429af5c8522678536
      https://github.com/llvm/llvm-project/commit/878c141adcd3a1ea47c4cc8429af5c8522678536
  Author: Lily Brown <lily at lily.fyi>
  Date:   2024-05-08 (Wed, 08 May 2024)

  Changed paths:
    M mlir/include/mlir/Tools/lsp-server-support/Protocol.h
    M mlir/lib/Tools/lsp-server-support/Protocol.cpp
    M mlir/unittests/Tools/lsp-server-support/CMakeLists.txt
    A mlir/unittests/Tools/lsp-server-support/Protocol.cpp

  Log Message:
  -----------
  [mlir-lsp] Add DiagnosticTag from LSP spec (#91396)

Adds the [DiagnosticTag][diagtag] LSP construct to the LSP support
headers. I also added a unit test file to validate that the `tags` array
is omitted entirely if it's empty.

The LSP spec requires that `Diagnostic::tags` be an array; in order to
conform to that I used `std::vector`, as `SmallVector` doesn't have JSON
decoding support (you can encode it to JSON, but not decode it from
JSON).

[diagtag]:
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.18/specification/#diagnosticTag



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications