[all-commits] [llvm/llvm-project] 43d089: [BOLT] Fix handling of trailing entries in jump ta...

Maksim Panchenko via All-commits all-commits at lists.llvm.org
Thu Apr 11 16:26:44 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 43d0891d3bb1fc40ff5dcea91c28d1582978caff
      https://github.com/llvm/llvm-project/commit/43d0891d3bb1fc40ff5dcea91c28d1582978caff
  Author: Maksim Panchenko <maks at fb.com>
  Date:   2024-04-11 (Thu, 11 Apr 2024)

  Changed paths:
    M bolt/lib/Core/BinaryContext.cpp
    A bolt/test/runtime/X86/jt-confusion.s

  Log Message:
  -----------
  [BOLT] Fix handling of trailing entries in jump tables (#88444)

If a jump table has entries at the end that are a result of
__builtin_unreachable() targets, BOLT can confuse them with function
pointers. In such case, we should exclude these targets from the table
as we risk incorrectly updating the function pointers. It is safe to
exclude them as branching on such targets is considered an undefined
behavior.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list