[all-commits] [llvm/llvm-project] 95fbd8: [clangd] Don't ignore external HFI in `SymbolColle...

Jan Svoboda via All-commits all-commits at lists.llvm.org
Thu Apr 11 15:23:03 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 95fbd8d19dff10b5a734e3db1b29cba2da7a983f
      https://github.com/llvm/llvm-project/commit/95fbd8d19dff10b5a734e3db1b29cba2da7a983f
  Author: Jan Svoboda <jan_svoboda at apple.com>
  Date:   2024-04-11 (Thu, 11 Apr 2024)

  Changed paths:
    M clang-tools-extra/clangd/index/SymbolCollector.cpp

  Log Message:
  -----------
  [clangd] Don't ignore external HFI in `SymbolCollector` (#88446)

The `FileEntry` corresponds to a `FileID` containing the
`SourceLocation` of a `NamedDecl` which (I think) might've been
deserialized from a PCM file. Considering external `HeaderFileInfo` here
is most likely the right thing to do here in order to get the correct
spelling in case the current compiler instance has not register this
file as a header yet.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list