[all-commits] [llvm/llvm-project] 61ea1b: [VectorCombine][X86] Add test coverage for #67803

[Simon Pilgrim via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 61ea1bc23aa941714be3ec818c922e4ee5a279a3
      https://github.com/llvm/llvm-project/commit/61ea1bc23aa941714be3ec818c922e4ee5a279a3
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2024-04-11 (Thu, 11 Apr 2024)

  Changed paths:
    A llvm/test/Transforms/VectorCombine/X86/pr67803.ll

  Log Message:
  -----------
  [VectorCombine][X86] Add test coverage for #67803

We are still missing a fold for shuffle(bitcast(sext(x)),bitcast(sext(y))) -> bitcast(sext(shuffle(x,y))) due to foldShuffleOfCastops failing to add new instructions back onto the worklist


  Commit: ff74236f342c7bc185f56a07bab7bd0cf356c7c6
      https://github.com/llvm/llvm-project/commit/ff74236f342c7bc185f56a07bab7bd0cf356c7c6
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2024-04-11 (Thu, 11 Apr 2024)

  Changed paths:
    M llvm/lib/Transforms/Vectorize/VectorCombine.cpp
    M llvm/test/Transforms/VectorCombine/X86/pr67803.ll

  Log Message:
  -----------
  [VectorCombine] foldShuffleOfCastops - ensure we add all new instructions onto the worklist

When creating cast(shuffle(x,y)) we were only adding the cast() to the worklist, not the new shuffle, preventing recursive combines.

foldShuffleOfBinops is also failing to do this, but I still need to add test coverage for this.


Compare: https://github.com/llvm/llvm-project/compare/599adf30afe5...ff74236f342c

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications