[all-commits] [llvm/llvm-project] e3311c: LAA cannot vectorize lib calls like modf/modff

Paschalis Mpeis via All-commits all-commits at lists.llvm.org
Thu Apr 11 02:16:10 PDT 2024


  Branch: refs/heads/users/paschalis-mpeis/laa-vectorize-modf
  Home:   https://github.com/llvm/llvm-project
  Commit: e3311c213197e43e2129dfdb73aa696c3805c59f
      https://github.com/llvm/llvm-project/commit/e3311c213197e43e2129dfdb73aa696c3805c59f
  Author: Paschalis Mpeis <Paschalis.Mpeis at arm.com>
  Date:   2024-04-11 (Thu, 11 Apr 2024)

  Changed paths:
    A clang/test/CodeGen/aarch64-veclib-function-calls-linear-ptrs.c

  Log Message:
  -----------
  LAA cannot vectorize lib calls like modf/modff

Functions like modf/modff are math lib calls that set memory write-only
attribute. Given that a target has vectorized mappings, LAA should allow
vectorization.


  Commit: 13ce51602a914b7183685572bc04abfdca29aa8d
      https://github.com/llvm/llvm-project/commit/13ce51602a914b7183685572bc04abfdca29aa8d
  Author: Paschalis Mpeis <Paschalis.Mpeis at arm.com>
  Date:   2024-04-11 (Thu, 11 Apr 2024)

  Changed paths:
    M clang/test/CodeGen/aarch64-veclib-function-calls-linear-ptrs.c
    M llvm/lib/Analysis/LoopAccessAnalysis.cpp

  Log Message:
  -----------
  [LV][LAA] Vectorize math lib calls with mem write-only attribute

Teach LAA to consider safe specific math lib calls which are known to
have set the memory write-only attribute. Those attributes are set to
calls by inferNonMandatoryLibFuncAttrs, in BuildLibCalls.cpp, and the
current ones are modf/modff and frexp/frexpf.

This happens only when the calls are found through TLI to have
vectorized counterparts.


  Commit: 29051f1beb86301d4897ac5dde9fc49528fd5bd0
      https://github.com/llvm/llvm-project/commit/29051f1beb86301d4897ac5dde9fc49528fd5bd0
  Author: Paschalis Mpeis <Paschalis.Mpeis at arm.com>
  Date:   2024-04-11 (Thu, 11 Apr 2024)

  Changed paths:
    M llvm/lib/Analysis/LoopAccessAnalysis.cpp

  Log Message:
  -----------
  Add check for the 'memory(argmem: write)' attribute.


  Commit: c388fdae94e8a7651ebe8449953c1ed21ddadeeb
      https://github.com/llvm/llvm-project/commit/c388fdae94e8a7651ebe8449953c1ed21ddadeeb
  Author: Paschalis Mpeis <Paschalis.Mpeis at arm.com>
  Date:   2024-04-11 (Thu, 11 Apr 2024)

  Changed paths:
    M clang/test/CodeGen/aarch64-veclib-function-calls-linear-ptrs.c
    M llvm/lib/Analysis/LoopAccessAnalysis.cpp

  Log Message:
  -----------
  Addressing reviewers


  Commit: 39b67b154dbae6676b471ccc402fd30b96b63f04
      https://github.com/llvm/llvm-project/commit/39b67b154dbae6676b471ccc402fd30b96b63f04
  Author: Paschalis Mpeis <Paschalis.Mpeis at arm.com>
  Date:   2024-04-11 (Thu, 11 Apr 2024)

  Changed paths:
    M clang/test/CodeGen/aarch64-veclib-function-calls-linear-ptrs.c

  Log Message:
  -----------
  Rebased and updated test after PR #80296


  Commit: 7ff8089d35fdb484375f9da4e97f0a6cab4b876b
      https://github.com/llvm/llvm-project/commit/7ff8089d35fdb484375f9da4e97f0a6cab4b876b
  Author: Paschalis Mpeis <Paschalis.Mpeis at arm.com>
  Date:   2024-04-11 (Thu, 11 Apr 2024)

  Changed paths:
    R clang/test/CodeGen/aarch64-veclib-function-calls-linear-ptrs.c
    M llvm/lib/Analysis/LoopAccessAnalysis.cpp
    A llvm/test/Analysis/LoopAccessAnalysis/attr-mem-write-only.ll
    A llvm/test/Transforms/LoopVectorize/AArch64/veclib-function-calls-linear-ptrs.ll

  Log Message:
  -----------
  Added LAA and LV tests

Removed C test.
Code rebased on top of patch that enables mappings for modf/modff
(among others).


Compare: https://github.com/llvm/llvm-project/compare/513ba7ad5ee6...7ff8089d35fd

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list