[all-commits] [llvm/llvm-project] 5d9d74: Remove the unused IntervalPartition analysis pass ...

Björn Pettersson via All-commits all-commits at lists.llvm.org
Tue Apr 9 11:12:47 PDT 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5d9d740c39a6cf21f0d54ec572aed3c2f556cbcb
      https://github.com/llvm/llvm-project/commit/5d9d740c39a6cf21f0d54ec572aed3c2f556cbcb
  Author: Björn Pettersson <bjorn.a.pettersson at ericsson.com>
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
    R llvm/include/llvm/Analysis/Interval.h
    R llvm/include/llvm/Analysis/IntervalIterator.h
    R llvm/include/llvm/Analysis/IntervalPartition.h
    M llvm/include/llvm/InitializePasses.h
    M llvm/include/llvm/LinkAllPasses.h
    M llvm/lib/Analysis/Analysis.cpp
    M llvm/lib/Analysis/CMakeLists.txt
    R llvm/lib/Analysis/Interval.cpp
    R llvm/lib/Analysis/IntervalPartition.cpp
    M llvm/lib/CodeGen/AssignmentTrackingAnalysis.cpp
    M llvm/utils/gn/secondary/llvm/lib/Analysis/BUILD.gn

  Log Message:
  -----------
  Remove the unused IntervalPartition analysis pass (#88133)

This removes the old legacy PM "intervals" analysis pass (aka
IntervalPartition). It also removes the associated Interval and
IntervalIterator help classes.

Reasons for removal:
1) The pass is not used by llvm-project (not even being tested by
   any regression tests).
2) Pass has not been ported to new pass manager, which at least
   indicates that it isn't used by the middle-end.
3) ASan reports heap-use-after-free on
      ++I;  // After the first one...
   even if false is passed to intervals_begin. Not sure if that is
   a false positive, but it makes the code a bit less trustworthy.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list