[all-commits] [llvm/llvm-project] 85a52b: [MLIR][OpenMP] Group clause operands into structur...

[Sergio Afonso via All-commits]

  Branch: refs/heads/users/skatrak/spr/clause-operands-01-mlir
  Home:   https://github.com/llvm/llvm-project
  Commit: 85a52b604ddabdd28cbc25d482879f47ecb8c4c0
      https://github.com/llvm/llvm-project/commit/85a52b604ddabdd28cbc25d482879f47ecb8c4c0
  Author: Sergio Afonso <safonsof at amd.com>
  Date:   2024-04-09 (Tue, 09 Apr 2024)

  Changed paths:
    A mlir/include/mlir/Dialect/OpenMP/OpenMPClauseOperands.h
    M mlir/include/mlir/Dialect/OpenMP/OpenMPDialect.h
    M mlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
    M mlir/lib/Dialect/OpenMP/IR/OpenMPDialect.cpp

  Log Message:
  -----------
  [MLIR][OpenMP] Group clause operands into structures and use them to define simplified op builders

This patch introduces a set of composable structures grouping the MLIR operands
associated to each OpenMP clause. This makes it easier to keep the MLIR
representation for the same clause consistent throughout all operations that
accept it.

The relevant clause operand structures are grouped into per-operation
structures using a mixin pattern and used to define new operation constructors.
These constructors can be used to avoid having to get the order of a possibly
large list of operands right.

Missing clauses are documented as TODOs, as well as operands which are part of
the relevant operation's operand structure but cannot be attached to the
associated operation yet, due to missing op arguments to its MLIR definition.

A follow-up patch will update Flang lowering to make use of these structures,
simplifying the passing of information from clause processing to operation-
generating functions and also simplifying the creation of operations through
the use of the new operation constructors.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications