[all-commits] [llvm/llvm-project] 4405e0: [mlir][OpenMP] map argument to reduction initializ...

[Tom Eccles via All-commits]

  Branch: refs/heads/users/tblah/omp_assumed_shape_reduction_2
  Home:   https://github.com/llvm/llvm-project
  Commit: 4405e0d11855c862a293c94588e5b3c430980aa5
      https://github.com/llvm/llvm-project/commit/4405e0d11855c862a293c94588e5b3c430980aa5
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2024-04-04 (Thu, 04 Apr 2024)

  Changed paths:
    M mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp
    A mlir/test/Target/LLVMIR/openmp-reduction-init-arg.mlir

  Log Message:
  -----------
  [mlir][OpenMP] map argument to reduction initialization region

The argument to the initialization region of reduction declarations was
never mapped. This meant that if this argument was accessed inside the
initialization region, that mlir operation would be translated to an
llvm operation with a null argument (failing verification).

Adding the mapping ensures that the right LLVM value can be found when
inlining and converting the initialization region.

We have to separately establish and clean up these mappings for each use
of the reduction declaration because repeated usage of the same
declaration will inline it using a different concrete value for the
block argument.


  Commit: e92d23ca6c8261e2a95f1a7cf212419fc4ee24e2
      https://github.com/llvm/llvm-project/commit/e92d23ca6c8261e2a95f1a7cf212419fc4ee24e2
  Author: Tom Eccles <tom.eccles at arm.com>
  Date:   2024-04-04 (Thu, 04 Apr 2024)

  Changed paths:
    M mlir/test/Target/LLVMIR/openmp-reduction-init-arg.mlir

  Log Message:
  -----------
  Simplify test


Compare: https://github.com/llvm/llvm-project/compare/92bd5f1b42b5...e92d23ca6c82

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications