[all-commits] [llvm/llvm-project] ed5fe6: [RemoveDIs][BC] Reject intrinsic->record upgrades ...

[Stephen Tozer via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: ed5fe66370cb0ea88913458d71959407dc7b1394
      https://github.com/llvm/llvm-project/commit/ed5fe66370cb0ea88913458d71959407dc7b1394
  Author: Stephen Tozer <stephen.tozer at sony.com>
  Date:   2024-04-04 (Thu, 04 Apr 2024)

  Changed paths:
    M llvm/include/llvm/IR/AutoUpgrade.h
    M llvm/lib/IR/AutoUpgrade.cpp

  Log Message:
  -----------
  [RemoveDIs][BC] Reject intrinsic->record upgrades for old-format modules (#87494)

Fixes issue noted at: https://github.com/llvm/llvm-project/pull/86274

When loading bitcode lazily, we may request debug intrinsics be upgraded
to debug records during the module parsing phase; later on we perform
this upgrade when materializing the module functions. If we change the
module's debug info format between parsing and materializing however,
then the requested upgrade is no longer correct and leads to an
assertion. This patch fixes the issue by adding an extra check in the
autoupgrader to see if the upgrade is no longer suitable, and either
exit-out or fall back to the correct intrinsic->intrinsic upgrade if one
is required.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications