[all-commits] [llvm/llvm-project] 7755c2: [SCEV] Include type when printing constant max bac...

Wed Mar 6 08:48:46 PST 2024

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 7755c26195900fa5611cd87582acd2f1875d3c40
      https://github.com/llvm/llvm-project/commit/7755c26195900fa5611cd87582acd2f1875d3c40
  Author: Philip Reames <preames at rivosinc.com>
  Date:   2024-03-06 (Wed, 06 Mar 2024)

  Changed paths:
    M llvm/lib/Analysis/ScalarEvolution.cpp
    M llvm/test/Analysis/ScalarEvolution/2008-11-18-Stride1.ll
    M llvm/test/Analysis/ScalarEvolution/2008-11-18-Stride2.ll
    M llvm/test/Analysis/ScalarEvolution/add-like-or.ll
    M llvm/test/Analysis/ScalarEvolution/addrec-computed-during-addrec-calculation.ll
    M llvm/test/Analysis/ScalarEvolution/addrec-sub-nsw.ll
    M llvm/test/Analysis/ScalarEvolution/alloca.ll
    M llvm/test/Analysis/ScalarEvolution/backedge-taken-count-guard-info.ll
    M llvm/test/Analysis/ScalarEvolution/becount-invalidation.ll
    M llvm/test/Analysis/ScalarEvolution/decrementing_addrecs.ll
    M llvm/test/Analysis/ScalarEvolution/exact-exit-count-more-precise.ll
    M llvm/test/Analysis/ScalarEvolution/exhaustive-trip-counts.ll
    M llvm/test/Analysis/ScalarEvolution/exit-count-select-safe.ll
    M llvm/test/Analysis/ScalarEvolution/exit-count-select.ll
    M llvm/test/Analysis/ScalarEvolution/exponential-behavior.ll
    M llvm/test/Analysis/ScalarEvolution/finite-trip-count.ll
    M llvm/test/Analysis/ScalarEvolution/flags-from-poison-noautogen.ll
    M llvm/test/Analysis/ScalarEvolution/flags-from-poison.ll
    M llvm/test/Analysis/ScalarEvolution/fold.ll
    M llvm/test/Analysis/ScalarEvolution/huge-trip-multiple.ll
    M llvm/test/Analysis/ScalarEvolution/incorrect-exit-count.ll
    M llvm/test/Analysis/ScalarEvolution/increasing-or-decreasing-iv.ll
    M llvm/test/Analysis/ScalarEvolution/invalidation.ll
    M llvm/test/Analysis/ScalarEvolution/load-with-range-metadata.ll
    M llvm/test/Analysis/ScalarEvolution/load.ll
    M llvm/test/Analysis/ScalarEvolution/logical-operations.ll
    M llvm/test/Analysis/ScalarEvolution/max-backedge-taken-count-guard-info-rewrite-expressions.ll
    M llvm/test/Analysis/ScalarEvolution/max-backedge-taken-count-guard-info.ll
    M llvm/test/Analysis/ScalarEvolution/max-backedge-taken-count-limit-by-wrapping.ll
    M llvm/test/Analysis/ScalarEvolution/max-be-count-not-constant.ll
    M llvm/test/Analysis/ScalarEvolution/max-expr-cache.ll
    M llvm/test/Analysis/ScalarEvolution/max-trip-count-address-space.ll
    M llvm/test/Analysis/ScalarEvolution/max-trip-count.ll
    M llvm/test/Analysis/ScalarEvolution/min-max-exprs.ll
    M llvm/test/Analysis/ScalarEvolution/ne-overflow.ll
    M llvm/test/Analysis/ScalarEvolution/no-wrap-symbolic-becount.ll
    M llvm/test/Analysis/ScalarEvolution/nsw-offset-assume.ll
    M llvm/test/Analysis/ScalarEvolution/nsw-offset.ll
    M llvm/test/Analysis/ScalarEvolution/nsw.ll
    M llvm/test/Analysis/ScalarEvolution/outer_phi.ll
    M llvm/test/Analysis/ScalarEvolution/overflow-intrinsics-trip-count.ll
    M llvm/test/Analysis/ScalarEvolution/overflow-intrinsics.ll
    M llvm/test/Analysis/ScalarEvolution/pr25369.ll
    M llvm/test/Analysis/ScalarEvolution/pr34538.ll
    M llvm/test/Analysis/ScalarEvolution/pr48225.ll
    M llvm/test/Analysis/ScalarEvolution/ptrtoint-constantexpr-loop.ll
    M llvm/test/Analysis/ScalarEvolution/ptrtoint.ll
    M llvm/test/Analysis/ScalarEvolution/range-signedness.ll
    M llvm/test/Analysis/ScalarEvolution/range_nw_flag.ll
    M llvm/test/Analysis/ScalarEvolution/ranges.ll
    M llvm/test/Analysis/ScalarEvolution/sdiv.ll
    M llvm/test/Analysis/ScalarEvolution/sext-add-inreg-loop.ll
    M llvm/test/Analysis/ScalarEvolution/sext-mul.ll
    M llvm/test/Analysis/ScalarEvolution/sext-to-zext.ll
    M llvm/test/Analysis/ScalarEvolution/shift-op.ll
    M llvm/test/Analysis/ScalarEvolution/shift-recurrences.ll
    M llvm/test/Analysis/ScalarEvolution/sle.ll
    M llvm/test/Analysis/ScalarEvolution/smax-br-phi-idioms.ll
    M llvm/test/Analysis/ScalarEvolution/smin-smax-folds.ll
    M llvm/test/Analysis/ScalarEvolution/solve-quadratic-i1.ll
    M llvm/test/Analysis/ScalarEvolution/solve-quadratic-overflow.ll
    M llvm/test/Analysis/ScalarEvolution/srem.ll
    M llvm/test/Analysis/ScalarEvolution/symbolic_max_exit_count.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count-andor-selectform.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count-andor.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count-implied-addrec.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count-minmax.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count-negative-stride.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count-pow2.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count-switch.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count-unknown-stride.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count10.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count12.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count13.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count14.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count15.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count2.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count3.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count4.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count6.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count7.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count8.ll
    M llvm/test/Analysis/ScalarEvolution/trip-count9.ll
    M llvm/test/Analysis/ScalarEvolution/trip-multiple-guard-info.ll
    M llvm/test/Analysis/ScalarEvolution/trip-multiple.ll
    M llvm/test/Analysis/ScalarEvolution/umin-umax-folds.ll
    M llvm/test/Analysis/ScalarEvolution/unknown_phis.ll
    M llvm/test/Analysis/ScalarEvolution/widenable-condition.ll
    M llvm/test/Transforms/LoopDeletion/invalidate-scev-after-hoisting.ll
    M llvm/test/Transforms/LoopSimplify/preserve-scev.ll

  Log Message:
  -----------
  [SCEV] Include type when printing constant max backedge taken count

When printing the result of the analysis, i8 -1 and i64 -1 are quite
different in terms of analysis quality.  In a recent conversion with
a new contributor, we ran into exactly this confusion.

Adding the type for constant scevs more globally seems worthwhile, but
introduces a much larger test diff.  I'm splitting this off first since
it addresses the immediate need, and then going to do some further
changes to clarify a few related bits of analysis result output.

To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications