[all-commits] [llvm/llvm-project] 2fb764: [libomptarget] Fix 'libomptarget' libraries being ...

Joseph Huber via All-commits all-commits at lists.llvm.org
Fri Mar 1 13:52:33 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 2fb764d2dae288f24335dfc168b5491a1017fc83
      https://github.com/llvm/llvm-project/commit/2fb764d2dae288f24335dfc168b5491a1017fc83
  Author: Joseph Huber <huberjn at outlook.com>
  Date:   2024-03-01 (Fri, 01 Mar 2024)

  Changed paths:
    M openmp/libomptarget/plugins-nextgen/CMakeLists.txt
    M openmp/libomptarget/plugins-nextgen/amdgpu/CMakeLists.txt
    M openmp/libomptarget/plugins-nextgen/cuda/CMakeLists.txt
    M openmp/libomptarget/src/CMakeLists.txt

  Log Message:
  -----------
  [libomptarget] Fix 'libomptarget' libraries being installed twice (#83624)

Summary:
We use `add_llvm_library` as a shorthand for setting up all the
dependencies and libraries we need for the OpenMP offloading runtime as
they depend on a lot of the LLVM utilities. However, we always
explicitly installed these manually. Behind the scenes the function
would then install it again. This was unnoticed because until now the
destinations matched. Now that we want it to optionally go into the
other directory it is duplicating them. Fix this by stating that this is
a build tree only library so we can handle it ourselves.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list