[all-commits] [llvm/llvm-project] cd344a: [LLDB] Fix completion of space-only lines in the R...

Walter Erquinigo via All-commits all-commits at lists.llvm.org
Wed Feb 28 08:43:49 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: cd344a4c20e295d49f8163ec9a0656c1061a6e42
      https://github.com/llvm/llvm-project/commit/cd344a4c20e295d49f8163ec9a0656c1061a6e42
  Author: Walter Erquinigo <a20012251 at gmail.com>
  Date:   2024-02-28 (Wed, 28 Feb 2024)

  Changed paths:
    M lldb/source/Host/common/Editline.cpp
    M lldb/test/API/repl/clang/TestClangREPL.py

  Log Message:
  -----------
  [LLDB] Fix completion of space-only lines in the REPL on Linux (#83203)

https://github.com/modularml/mojo/issues/1796 discovered that if you try
to complete a space-only line in the REPL on Linux, LLDB crashes. I
suspect that editline doesn't behave the same way on linux and on
darwin, because I can't replicate this on darwin.

Adding a boundary check in the completion code prevents the crash from
happening.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list