[all-commits] [llvm/llvm-project] 259409: Replace ArchSpec::PiecewiseCompare() with Triple::...

[Adrian Prantl via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 25940956e68ec82d841e5748565e7250580e1d36
      https://github.com/llvm/llvm-project/commit/25940956e68ec82d841e5748565e7250580e1d36
  Author: Adrian Prantl <adrian-prantl at users.noreply.github.com>
  Date:   2024-02-23 (Fri, 23 Feb 2024)

  Changed paths:
    M lldb/include/lldb/Utility/ArchSpec.h
    M lldb/source/Target/Target.cpp
    M lldb/source/Utility/ArchSpec.cpp
    A lldb/test/API/macosx/arm64e-attach/Makefile
    A lldb/test/API/macosx/arm64e-attach/TestArm64eAttach.py
    A lldb/test/API/macosx/arm64e-attach/main.c

  Log Message:
  -----------
  Replace ArchSpec::PiecewiseCompare() with Triple::operator==() (#82804)

Looking ast the definition of both functions this is *almost* an NFC
change, except that Triple also looks at the SubArch (important) and
ObjectFormat (less so).

This fixes a bug that only manifests with how Xcode uses the SBAPI to
attach to a process by name: it guesses the architecture based on the
system. If the system is arm64 and the Process is arm64e Target fails to
update the triple because it deemed the two to be equivalent.

rdar://123338218



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications