[all-commits] [llvm/llvm-project] 492e8b: [mlir] Fix memory leaks after #81759 (#82762)

Matthias Springer via All-commits all-commits at lists.llvm.org
Fri Feb 23 05:29:09 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 492e8ba0384b038596e6b4a97313b7bdced5e868
      https://github.com/llvm/llvm-project/commit/492e8ba0384b038596e6b4a97313b7bdced5e868
  Author: Matthias Springer <me at m-sp.org>
  Date:   2024-02-23 (Fri, 23 Feb 2024)

  Changed paths:
    M mlir/lib/Dialect/GPU/IR/GPUDialect.cpp
    M mlir/lib/Dialect/SCF/IR/SCF.cpp

  Log Message:
  -----------
  [mlir] Fix memory leaks after #81759 (#82762)

This commit fixes memory leaks that were introduced by #81759. The way
ops and blocks are erased changed slightly.

The leaks were caused by an incorrect implementation of op builders:
blocks must be created with the supplied builder object. Otherwise, they
are not properly tracked by the dialect conversion and can leak during
rollback.



To unsubscribe from these emails, change your notification settings at https://github.com/llvm/llvm-project/settings/notifications


More information about the All-commits mailing list